Refactor cycle_sort and add comprehensive test cases#929
Closed
ShringariV wants to merge 2 commits into
Closed
Conversation
Refactored cycle_sort for improved readability and conciseness by simplifying the nested loops and removing redundant comments. Added multiple test cases to cover various scenarios, including already sorted, reverse sorted, single element, empty arrays, arrays with duplicates, large random arrays, and arrays with negative numbers.
Refactored cycle_sort for improved readability and conciseness by simplifying the nested loops and removing redundant comments. Added multiple test cases to cover various scenarios, including already sorted, reverse sorted, single element, empty arrays, arrays with duplicates, large random arrays, and arrays with negative numbers.
Owner
|
Thanks for the improved comments and tests! The repo was restructured in v1.0.0 and the existing cycle_sort was updated with ruff compliance. Closing as the changes no longer apply. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored cycle_sort for improved readability and conciseness by simplifying the nested loops and removing redundant comments. Added multiple test cases to cover various scenarios, including already sorted, reverse sorted, single element, empty arrays, arrays with duplicates, large random arrays, and arrays with negative numbers.